Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite resolve #13449

Closed
brson opened this issue Apr 10, 2014 · 11 comments
Closed

Rewrite resolve #13449

brson opened this issue Apr 10, 2014 · 11 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically P-low Low priority

Comments

@brson
Copy link
Contributor

brson commented Apr 10, 2014

I've heard from multiple people that resolve needs a complete rewrite. Nominating.

cc #11870 #3352

@nikomatsakis
Copy link
Contributor

cc me

@nikomatsakis
Copy link
Contributor

Additional tasks: clarify our rules (I have a plan, will post RFC soon)

@pnkfelix
Copy link
Member

Not 1.0; marking P-high.

@flaper87
Copy link
Contributor

cc #5765

@emberian
Copy link
Member

Again \o/

@gereeter
Copy link
Contributor

I'm working on this - just by reading and working on the code myself I have a pretty good idea of some major restructurings that ought to be done, but I'd greatly appreciate information about what others think needs to be fixed.

@gereeter
Copy link
Contributor

More specifically, I plan to separate the passes of resolve to break the implicit data dependencies, make Module into an actual tree without any reference counting, use &mut for mutation instead of RefCell, and put things like import resolutions into side tables that hold borrowed pointers into the module tree.

@alexcrichton
Copy link
Member

triage: P-low

@rust-highfive rust-highfive added P-low Low priority and removed P-medium Medium priority labels Apr 20, 2015
@steveklabnik
Copy link
Member

Triage: what would make this ticket actionable? the last meaningful comment was 18 months ago.

@hanna-kruppe
Copy link
Contributor

Since the last meaningful comment has been made in October 2014, resolve has been split out into its own crate and touched by almost one thousand commits, including 87 that include the word "refactor" in their one-line commit message. Whatever code this issue originally referred to, odds are it's completely unrecognizable/gone by now.

@eddyb
Copy link
Member

eddyb commented Jan 5, 2017

@petrochenkov and @jseyfried (and other people I forget now, sorry!) have put a lot of work into it :shipit:

@eddyb eddyb closed this as completed Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically P-low Low priority
Projects
None yet
Development

No branches or pull requests