We should build ALL Rust code in this repo in CI

[safinaskar]

We should build ALL Rust code in this repo when we do ./x test in CI. Including subtrees. This is needed to ensure that contributors will not occasionally break anything, especially when doing tree-wide changes.

For example, in #134420 a contributor replaced tree-wide &PathBuf with &Path. Unfortunately, he broke ./x perf. This was not noticed, because src/tools/rustc-perf-wrapper is not built during ./x test CI. (Later he fixed that problem.)

So, please, build everything in ./x test CI, including subtrees.

I add "contributor roadblock", because I think this is minor contributor roadblock.

@rustbot label A-contributor-roadblock C-enhancement -C-bug

HEAD

fd19773

[onur-ozkan]

We can't compile all Rust code with the x test command because some dependencies are gated by config.toml and the host machine, but we can definitely extend the scope of x test compilation.

[cuviper]

For downstream builds, I appreciate that the current x test covers pretty much what I'm going to ship, whereas stuff like perf is not really relevant. If the default x test grew, then it would be annoying to manually enumerate all the things it used to cover.

So maybe there should be a broader pseudo-target for those that want more, like x test all, or maybe the other way with some name that means the smaller set it used to test. Or maybe there could be a config with different defaults between profiles.

[safinaskar]

@cuviper , what I really meant is "to build all code in CI". I updated my post and title