Skip to content

compiletest: investigate if compare-mode nits are still relevant #136513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jieyouxu opened this issue Feb 3, 2025 · 0 comments
Open

compiletest: investigate if compare-mode nits are still relevant #136513

jieyouxu opened this issue Feb 3, 2025 · 0 comments
Labels
A-compiletest Area: The compiletest test runner A-compiletest-compare-modes Area: compiletest compare-modes C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Feb 3, 2025

also, I don't know if this is exactly relevant to this particular PR, but during my experimentation: When I created an empty augmented-assignments.nll.stderr file, I expected to see a diff that just showed all plusses. (I.e., a diff against an empty file)

But instead it seems like if the revision file is empty, then it falls back on the base file augmented-assignments.stderr, in this particular case...

  • (From skimming the PR, I'm not even clear on how we are observing such a semantics... but nonetheless, it is what I am seeing.)

(I don't know whether other people think that fall back behavior for empty files is more intutive... it wasn't intuitive for me, since I'm the kind of person who will just do touch augmented-assignments.nll.stderr and then run the tool to see what the content is that I need to add.)

Originally posted by @pnkfelix in #49293 (comment)

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 3, 2025
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-compiletest Area: The compiletest test runner A-compiletest-compare-modes Area: compiletest compare-modes and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-compiletest-compare-modes Area: compiletest compare-modes C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
Development

No branches or pull requests

2 participants