Skip to content

compiletest accepts header directives that are not supported by a testsuite #137625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lolbinarycat opened this issue Feb 25, 2025 · 1 comment
Closed

compiletest accepts header directives that are not supported by a testsuite #137625

lolbinarycat opened this issue Feb 25, 2025 · 1 comment
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@lolbinarycat
Copy link
Contributor

For example, you can add normalize-stdout to a rustdoc test, and this will be accepted.

This is unexpected because compiletest will catch nonsense/typod directives, such as normalize-stdoutttttt.

Ideally, if you use an incompatible directive, you will get a warning/error that tells you that it is incompatible, along with which test suites it is compatible with.
@lolbinarycat lolbinarycat added A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks. labels Feb 25, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 25, 2025
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks. labels Feb 25, 2025
@jieyouxu
Copy link
Member

Duplicate of #128058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lolbinarycat @jieyouxu @rustbot