Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbidding import shadowing has bad interactions with pub use glob::* and tests #16890

Closed
andrew-d opened this issue Aug 30, 2014 · 3 comments
Closed

Comments

@andrew-d
Copy link
Contributor

In short, I'm working with sodiumoxide, and running tests fails with something like this:

src/sodiumoxide/crypto/secretbox.rs:26:9: 26:35 error: import `__test_reexports` conflicts with type in this module
src/sodiumoxide/crypto/secretbox.rs:26 pub use self::xsalsa20poly1305::*;
                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~
src/sodiumoxide/lib.rs:1:1: 1:1 note: note conflicting type here
src/sodiumoxide/lib.rs:1 /*!
                         ^
src/sodiumoxide/crypto/sign.rs:28:9: 28:26 error: import `__test_reexports` conflicts with type in this module
src/sodiumoxide/crypto/sign.rs:28 pub use self::ed25519::*;
                                          ^~~~~~~~~~~~~~~~~
src/sodiumoxide/lib.rs:1:1: 1:1 note: note conflicting type here
src/sodiumoxide/lib.rs:1 /*!
                         ^
src/sodiumoxide/crypto/shorthash.rs:17:9: 17:28 error: import `__test_reexports` conflicts with type in this module
src/sodiumoxide/crypto/shorthash.rs:17 pub use self::siphash24::*;
                                               ^~~~~~~~~~~~~~~~~~~
src/sodiumoxide/lib.rs:1:1: 1:1 note: note conflicting type here
src/sodiumoxide/lib.rs:1 /*!

There are actually more errors, all of the same format. This pretty much breaks pub use glob::* entirely - I haven't been able to find a workaround (short of just explicitly stating what to use, which kind of defeats the purpose).

@bkoropoff
Copy link
Contributor

This looks like #16597

@sfackler
Copy link
Member

Closing as a dupe of #16597.

@andrew-d
Copy link
Contributor Author

Aha, didn't see that one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants