Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dedicated search page to Rustdoc #18168

Closed
Gankra opened this issue Oct 19, 2014 · 7 comments
Closed

Add a dedicated search page to Rustdoc #18168

Gankra opened this issue Oct 19, 2014 · 7 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Gankra
Copy link
Contributor

Gankra commented Oct 19, 2014

Search is lazily loaded after the rest of the content on a given page. This makes searches, especially ones using in-browser search utilities, or jumping through search history really sluggish and unresponsive. A dedicated empty page optimized for this usecase would be greatly appreciated.
@Gankra
Copy link
Contributor Author

Gankra commented Oct 19, 2014

Related to #17296

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 27, 2015
@steveklabnik
Copy link
Member

Triage: no change.

@steveklabnik steveklabnik added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 22, 2017
@QuietMisdreavus QuietMisdreavus mentioned this issue Aug 7, 2017
Open
@steveklabnik
Copy link
Member

@rust-lang/rustdoc is this a feature we plan to implement?

@GuillaumeGomez
Copy link
Member

Isn't the search efficient enough now? If more search functionalities are wanted, we can always add them though.

@kzys
Copy link
Contributor

kzys commented Sep 28, 2018

+1 for resolving. Rustdoc is not that slow (or our machines are faster, compared to 2014).

For the standard library, the landing page now has a small search box.

@camelid
Copy link
Member

camelid commented Jan 9, 2022 •
edited
Loading

I'm not quite sure what this issue is requesting, and it does seem like the problem is resolved now. Shall we close the issue?

@GuillaumeGomez
Copy link
Member

Funnily enough, we will end up with something like that once our plan started with #90630 will be done.
So yes, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kzys @steveklabnik @Gankra @GuillaumeGomez @Mark-Simulacrum @camelid