Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler plugins with a private plugin_registrar function should not compile #19368

Closed
dcrewi opened this issue Nov 28, 2014 · 3 comments
Closed
Labels
A-syntaxext Area: Syntax extensions

Comments

@dcrewi
Copy link
Contributor

dcrewi commented Nov 28, 2014

rustc 0.13.0-dev (fac5a0767 2014-11-26 22:37:06 +0000)
binary: rustc
commit-hash: fac5a07679cac21a580badc84b755b8df0f975cf
commit-date: 2014-11-26 22:37:06 +0000
host: x86_64-unknown-linux-gnu
release: 0.13.0-dev

On this build, I'm seeing cargo successfully compile such a plugin without any error message. Crates that attempt to load the plugin then fail with a confusing "undefined symbol" error, which provides little assistance in locating the root of the problem.

I suggest that such a plugin should not even compile.

@huonw huonw added the A-syntaxext Area: Syntax extensions label Nov 28, 2014
@sfackler
Copy link
Member

cc #14841

@steveklabnik
Copy link
Member

Can confirm that this is still an issue. To reproduce, do #14841 (comment) and remove the pub.

That issue seems like a more general version of this one, but since it's not an exact duplicate, let's keep it open, I guess.

@Mark-Simulacrum
Copy link
Member

Closing in favor of #14841 -- I think that tracks the underlying cause here and as such is the problem; we don't need to track this separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions
Projects
None yet
Development

No branches or pull requests

5 participants