Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose begin_unwind somewhere besides libstd #21880

Closed
kmcallister opened this issue Feb 3, 2015 · 5 comments
Closed

Expose begin_unwind somewhere besides libstd #21880

kmcallister opened this issue Feb 3, 2015 · 5 comments
Labels
A-syntaxext Area: Syntax extensions

Comments

@kmcallister
Copy link
Contributor

It used to be in librustrt but that's gone now. This is currently blocking my ability to enable derive(Rand) and derive(Rustc{En,De}codable) for no-std crates.

@kmcallister kmcallister added the A-syntaxext Area: Syntax extensions label Feb 3, 2015
@Gankra
Copy link
Contributor

Gankra commented Feb 3, 2015

CC @aturon was this intended?

@aturon
Copy link
Member

aturon commented Feb 16, 2015

We haven't had a great stabilization story for this usage, and this was a byproduct of moving rustrt into std.

It should be easy enough to expose something on an experimental basis, but will take more thought to develop a long-term, stable design.

@kmcallister If you wanted to make a PR just making this stuff public under std::rt, I'd be open to that.

cc @alexcrichton

@kmcallister kmcallister self-assigned this Feb 16, 2015
@alexcrichton
Copy link
Member

Due to recent changes to stability lints we now have two stable functions:

I believe, however, that the motivation for this issue is to mirror the same structure in libstd as it is in libcore to allow #[macro_reexport] in the standard library. Both these deriving modes, however, rely on libraries that depend on the standard library, so I'm not sure how much more relevant the motivation is any more.

@kmcallister kmcallister removed their assignment Mar 2, 2015
@steveklabnik
Copy link
Member

begin_unwind is gone entirely, and i believe that panic handlers cover this use-case today. Is this still a valid bug?

@alexcrichton
Copy link
Member

Nah I don't think this is valid any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions
Projects
None yet
Development

No branches or pull requests

5 participants