Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tons of 404s due to sidebar-items.js #23900

Closed
steveklabnik opened this issue Mar 31, 2015 · 2 comments
Closed

tons of 404s due to sidebar-items.js #23900

steveklabnik opened this issue Mar 31, 2015 · 2 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@steveklabnik
Copy link
Member

related to #14515

in src/librustdoc/html/render.rs

2327         if parentlen == 0 {
2328             // there is no sidebar-items.js beyond the crate root path
2329             // FIXME maybe dynamic crate loading can be merged here
2330         } else {

I'm not sure if this codepath is the problem, but we have tons of 404s on sidebar-items.js not existing, because pages like http://doc.rust-lang.org/std/usize/index.html have ../sidebar-items.js, which is wrong.

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 31, 2015
@nhowell
Copy link
Contributor

nhowell commented Jun 30, 2015

I'm not seeing these 404s. Has it since been fixed?

Unrelated: I've noticed that the sidebar doesn't highlight the active module in the sidebar, though. (Structs, functions, et al. get highlighted when active, though). Seems like a bug to me.

@steveklabnik
Copy link
Member Author

I am not seeing them anymore as well, so I think this has. Thanks for the prompt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants