-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated and incorrect "Implementors" items #25061
Comments
Also noting that ArcInner is private and should not appear. |
Not only marker traits. From the bottom of Iterator doc page:
|
It should be noted (and I expect is related), that entries appear in what seems to be a completely random order. |
It should also be noted that some entries have links where others do not, see example in: rust-lang/prev.rust-lang.org#841. |
Update: this is still a bit of a thorn, though some of it has been fixed. The repetition is because of a thing rustdoc likes to do where dependent crates can fill out a javascript "implementors" file to let their implementations show up on the trait's page, even though the struct is being documented later than the trait. However, this does not take into account whether the trait or the struct have been re-exported. So in std, where several traits and structs come from other crates and are re-exported to be part of std as well, these implementations show up in both the regular render and the implementors javascript file. On a brighter note, it looks like rustdoc prints the trait bounds on all these impls now, so at least that part's been fixed. |
Maybe off-topic, but what's the point of these JavaScript-generated items being wrapped in tables? rust/src/librustdoc/html/static/main.js Lines 2087 to 2092 in 26373fb
|
Related: #85418 |
Closing this since it is has been fixed |
The docs pages for Send and Sync show duplicated and incorrect items in the "Implementors" section.
Specifically, an incorrect positive impl for
Rc
is present and the correct negative impl is present twice.Also, impls for
Arc
andArcInner
appear multiple times, with and without trait bounds andwhere
clauses, withArc
having three appearances:The text was updated successfully, but these errors were encountered: