You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
graydon opened this issue
Jun 20, 2012
· 4 comments
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.
Uint formatting was (for a time) using fixed-size buffers on the stack. It was changed to use variable sized heap buffers when merged with strconv. That path needs to be changed back to using stack buffers ("larger than the maximum formatted number size")
The text was updated successfully, but these errors were encountered:
The strconv change in the pull req above changed from a fast stack-allocated fixed-size buffer to a heap-allocated dynamic buffer. This is too slow to be on our regular number formatting path. I'll rename this bug to match the revised situation.
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.
Uint formatting was (for a time) using fixed-size buffers on the stack. It was changed to use variable sized heap buffers when merged with strconv. That path needs to be changed back to using stack buffers ("larger than the maximum formatted number size")
The text was updated successfully, but these errors were encountered: