Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc & test update after change in eh_unwind_resume signature #29898

Closed
tytouf opened this issue Nov 17, 2015 · 7 comments
Closed

Doc & test update after change in eh_unwind_resume signature #29898

tytouf opened this issue Nov 17, 2015 · 7 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools P-medium Medium priority

Comments

@tytouf
Copy link

tytouf commented Nov 17, 2015

When building a bare metal application with the nightly version of rustc 1.6.0-dev (3042fed 2015-11-16) I get an assert in LLVM:

rustc: /home/caugier/ws/rust/src/llvm/lib/IR/Instructions.cpp:234: void llvm::CallInst::init(llvm::FunctionType*, llvm::Value*, llvm::ArrayRef<llvm::Value*>, const llvm::Twine&): Assertion `(Args.size() == FTy->getNumParams() || (FTy->isVarArg() && Args.size() > FTy->getNumParams())) && "Calling a function with bad signature!"' failed.

After investigating a bit it seems the issue comes after a change in eh_unwind_resume signature from () to (*mut u8).

Doc needs to updated for sure, but I found that some tests are using it as well.

A validation of the signature would also help people when migrating by providing a specific error message.

@ticki
Copy link
Contributor

ticki commented Jan 13, 2016

Can confirm. This is still an error.

@carlpaten
Copy link

Ran into the same issue.

@steveklabnik
Copy link
Member

Which documentation is incorrect here?

@carlpaten
Copy link

  1. The error message is non-obvious
  2. The signature of eh_unwind_resume is not documented anywhere. When it changed, stuff stopped compiling overnight, and it was really hard to figure out why :|

@steveklabnik
Copy link
Member

related: #33677

@steveklabnik steveklabnik added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Mar 10, 2017
@steveklabnik steveklabnik added P-medium Medium priority and removed A-docs labels Mar 22, 2017
@frewsxcv
Copy link
Member

frewsxcv commented Jun 8, 2017

There's some documentation here now: https://doc.rust-lang.org/nightly/unstable-book/language-features/lang-items.html

Does this need to be expanded further?

@Mark-Simulacrum
Copy link
Member

I think that page is sufficient. I'm going to close this, in favor of more targeted issues being filed as users encounter problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

6 participants