Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export arc::exclusive from libcore #3119

Closed
bblum opened this issue Aug 7, 2012 · 2 comments
Closed

Don't export arc::exclusive from libcore #3119

bblum opened this issue Aug 7, 2012 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.5

Comments

@bblum
Copy link
Contributor

bblum commented Aug 7, 2012

We want to export arc::arc, but not arc::exclusive, to users of libcore... but libcore still needs to use it internally. Maybe the latter should have its own file, that isn't exported in core.rc.

Same with sys::lock_and_signal, I think.
@bblum
Copy link
Contributor Author

bblum commented Aug 7, 2012

Blocked on #2648

@bblum bblum mentioned this issue Aug 8, 2012
Closed
@bblum
Copy link
Contributor Author

bblum commented Aug 21, 2012

see rationale on #3144 for why this wasn't done.

@bblum bblum closed this as completed in 0229bc4 Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@bblum