Skip to content

move parts of rustrt/core to std #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Sep 3, 2012 · 4 comments
Closed

move parts of rustrt/core to std #3360

brson opened this issue Sep 3, 2012 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Sep 3, 2012

Some things that probably should be in std are in core and rt, primarily because rt is the only place we put native code.

Right now uv is linked to rt, but the bindings are (rightly imo) in std. There is also some native glue code used by the uv bindings. Deflate is in core, for use by the compiler, and I think this is probably because the native deflate code is in rt.

Core and rt are merging and will be statically linked in the future and things are not organized quite right.

I suggest the following:

  • Move core::flate to std, linking to rustrt
  • Rename rustrt to rustcore_native
  • Add ruststd_native, statically linked to std
  • Move uv and deflate native code to ruststd_native
  • Statically link rustrt to core Statically link the runtime to core #3361
@brson
Copy link
Contributor Author

brson commented Mar 31, 2013

Not 0.6

@bblum
Copy link
Contributor

bblum commented Jul 3, 2013

revisiting for triage; don't have anything to add

@huonw
Copy link
Member

huonw commented Sep 3, 2013

Triage: flate is now in extra, and the amount of code in rustrt is dropping dramatically as almost everything moves into std::rt.

I'd say this issue can be closed as out-of-date as it will happen naturally.

@brson
Copy link
Contributor Author

brson commented Oct 10, 2013

Closing. There's still more reorganization I'd like to do here, but this is pretty out of date.

@brson brson closed this as completed Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

3 participants