Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable/beta configure fails on macOS 10.12 (Apple clang 8.0) #34549

Closed
rahulg opened this issue Jun 29, 2016 · 3 comments
Closed

Stable/beta configure fails on macOS 10.12 (Apple clang 8.0) #34549

rahulg opened this issue Jun 29, 2016 · 3 comments

Comments

@rahulg
Copy link

rahulg commented Jun 29, 2016

Running configure on stable and beta branches on macOS 10.12 with the Xcode 8 command line tools fails with the following:

configure: error: bad APPLE CLANG version: 8.0.0, need >=7.0

The master branch shouldn't have this issue, since configure doesn't seem to whitelist Apple clang versions any more. The following one-line patch[1] fixes this issue on stable/beta:

diff --git a/configure b/configure
index fdef550..7a7b2e4 100755
--- a/configure
+++ b/configure
@@ -1023,7 +1023,7 @@ then
         if [ -n "$CFG_OSX_CLANG_VERSION" ]
         then
             case $CFG_OSX_CLANG_VERSION in
-                (7.0* | 7.1* | 7.2* | 7.3*)
+                (7.0* | 7.1* | 7.2* | 7.3* | 8.0*)
                 step_msg "found ok version of APPLE CLANG: $CFG_OSX_CLANG_VERSION"
                 ;;
                 (*)

[1] filed an issue instead of a PR since the PR wouldn't be against master

@alexcrichton
Copy link
Member

Ah yeah this should be fixed on master and we can be sure to backport the relevant change (#34383) to beta to ensure the next release (coming out next week) won't need that modification out of the box.

That's in the pipeline now so I'm gonna close this, but the next stable release should work just fine!

@rahulg
Copy link
Author

rahulg commented Jun 30, 2016

Thanks!

@asemoon
Copy link

asemoon commented Jun 9, 2017

The same problem exists with clang 8.1.0 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants