Skip to content

diagnostics: The compile-fail/lifetime-inference-give-expl-lifetime-param.rs test is unreliable #35038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jseyfried opened this issue Jul 25, 2016 · 3 comments
Closed

diagnostics: The compile-fail/lifetime-inference-give-expl-lifetime-param.rs test is unreliable #35038

jseyfried opened this issue Jul 25, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@jseyfried
Copy link
Contributor

The "consider using an explicit lifetime parameter" notes depend on the ids of interned strings, so they can differ between platforms after #34856.
@jseyfried
Copy link
Contributor Author

cc @nikomatsakis

@nikomatsakis nikomatsakis added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 25, 2016
@jseyfried jseyfried changed the title diagnostics: The compile-fail/lifetime-inference-give-expl-lifetime-param.rs is unreliable diagnostics: The compile-fail/lifetime-inference-give-expl-lifetime-param.rs test is unreliable Jul 25, 2016
@steveklabnik steveklabnik removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 25, 2017
@steveklabnik
Copy link
Member

Triage: it seems that this file no longer exists? Any idea where this test is now?

@Mark-Simulacrum
Copy link
Member

We removed this suggestion entirely in a2735c0 it seems so closing out (found by doing git log -- src/test/compile-fail/lifetime-inference-give-expl-lifetime-param.rs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @nikomatsakis @Mark-Simulacrum @jseyfried