Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0081 needs to be updated to new format #35224

Closed
sophiajt opened this issue Aug 2, 2016 · 2 comments
Closed

E0081 needs to be updated to new format #35224

sophiajt opened this issue Aug 2, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0081.rs

Error E0081 needs a span_label and a span_note replaced with span_label, updating it from:

error[E0081]: discriminant value `3isize` already exists
  --> src/test/compile-fail/E0081.rs:13:5
   |
13 |     X = 3, //~ ERROR E0081
   |     ^^^^^
   |
note: conflicting discriminant here
  --> src/test/compile-fail/E0081.rs:12:5
   |
12 |     P = 3,
   |     ^^^^^

to:

error[E0081]: discriminant value `3isize` already exists
  --> src/test/compile-fail/E0081.rs:13:5
   |
12 |     P = 3,
   |     ----- first use of `3isize`
13 |     X = 3, //~ ERROR E0081
   |     ^^^^^ enum already has `3isize`

Bonus: this may be nicer with spans that focus on the value.

error[E0081]: discriminant value `3isize` already exists
  --> src/test/compile-fail/E0081.rs:13:5
   |
12 |     P = 3,
   |         - first use of `3isize`
13 |     X = 3, //~ ERROR E0081
   |         ^ enum already has `3isize`
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Looks like #35353 didn't attempt the bonus. @poveda-ruiz are you going to finish this? Otherwise, I'm taking over.

@ghost
Copy link

ghost commented Aug 8, 2016

Take it over, I don't know how to do it :)

steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 10, 2016
…rner

Shrink span to variant discriminant expression for E0081

Part of rust-lang#35233.
Extension of rust-lang#35353.
Fixes rust-lang#35224.

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 10, 2016
…rner

Shrink span to variant discriminant expression for E0081

Part of rust-lang#35233.
Extension of rust-lang#35353.
Fixes rust-lang#35224.

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 11, 2016
…rner

Shrink span to variant discriminant expression for E0081

Part of rust-lang#35233.
Extension of rust-lang#35353.
Fixes rust-lang#35224.

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants