Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwinding on emscripten #36514

Closed
brson opened this issue Sep 16, 2016 · 5 comments
Closed

Fix unwinding on emscripten #36514

brson opened this issue Sep 16, 2016 · 5 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.

Comments

@brson
Copy link
Contributor

brson commented Sep 16, 2016

Today it's totally busted because, among other things, the libunwind symbols are unimplemented in emscripten. It may be worth having an unwinding path that uses libcxxabi for this target so that work doesn't need to be done in emscripten.
@brson brson added A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows A-libs E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. labels Sep 16, 2016
This was referenced Sep 16, 2016
Closed
Closed
@brson
Copy link
Contributor Author

brson commented Sep 17, 2016

I've started a patch to use the libcxxabi APIs on emscripten for unwinding.

@brson
Copy link
Contributor Author

brson commented Sep 19, 2016

My utterly broken patch is https://github.com/brson/rust/tree/emscripten-unwind. Not sure I will continue to make progress on it, but it would be good to at least get it into a state where we can enable ERROR_ON_UNDEFINED_SYMBOLS #36515

@brson
Copy link
Contributor Author

brson commented Sep 22, 2016

I've pushed a fix for this to #36339

@brson
Copy link
Contributor Author

brson commented Sep 23, 2016

I've pushed a patch to #36339

@brson
Copy link
Contributor Author

brson commented Oct 1, 2016

Fixed.

@brson brson closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson