Skip to content

Make sure all file extensions for wasm are correct #39355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brson opened this issue Jan 27, 2017 · 3 comments
Open

Make sure all file extensions for wasm are correct #39355

brson opened this issue Jan 27, 2017 · 3 comments
Labels
C-bug Category: This is a bug. O-wasm Target: WASM (WebAssembly), http://webassembly.org/

Comments

@brson
Copy link
Contributor

brson commented Jan 27, 2017

Per this comment, we only emit .js for bin targets, it's not clear what we emit for dylib, cdylib, and staticlib, but it seems likely they are incorrect.

I think .a is probably right for staticlib that is going to be run through emcc, but maybe dylibs should be .js.

@brson brson added O-asmjs Target: asm.js - http://asmjs.org/ O-wasm Target: WASM (WebAssembly), http://webassembly.org/ labels Jan 27, 2017
@eholk
Copy link
Contributor

eholk commented May 2, 2017

I think the dylib story will depend on how dynamic linking for WebAssembly works. Here is some thinking on the issue, but I don't think it's official or complete yet: https://github.com/WebAssembly/tool-conventions/blob/master/DynamicLinking.md

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
@steveklabnik
Copy link
Member

Triage: i have no idea if this was done or not.

@tlively
Copy link
Contributor

tlively commented Jan 9, 2020

AFAIK, the dynamic linking story for WebAssembly is still a WIP, so I wouldn't expect rustc to be able to produce WebAssembly dynamic libraries. On the other hand, I assume that once these library types are supported, their extensions will all match the standard Linux extensions, so I'm not sure this issue is still important to have around.

@workingjubilee workingjubilee removed the O-asmjs Target: asm.js - http://asmjs.org/ label Oct 29, 2023
@workingjubilee workingjubilee changed the title Make sure all file extensions for asm.js and wasm are correct Make sure all file extensions for wasm are correct Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-wasm Target: WASM (WebAssembly), http://webassembly.org/
Projects
None yet
Development

No branches or pull requests

6 participants