Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Book: Don't use "px" as font size unit #39768

Closed
StefanoD opened this issue Feb 12, 2017 · 4 comments
Closed

Rust Book: Don't use "px" as font size unit #39768

StefanoD opened this issue Feb 12, 2017 · 4 comments

Comments

@StefanoD
Copy link

Displays have different resolutions, so it is not recommended using px as font-size unit. It is better to use em or %.

@carols10cents
Copy link
Member

So @steveklabnik is in the process of moving the existing book to use mdBook, which is what the in-progress new book already uses. Taking a quick glance, it looks like mdBook's styling uses ems (it did everywhere I looked at least).

So I think PR #39633 will close this (I don't have permission to close this issue though :)).

@StefanoD
Copy link
Author

StefanoD commented Feb 12, 2017

Ok, thx. For the information.
i looked at the new book version and it is almost true what you say, but I could find one font-size declaration using px:

.menu-title {
  display: inline-block;
  font-weight: 200;
  font-size: 20px;
  //...
}

Maybe this was made on purpose, maybe not. I'm not really the web-dev guy. :)

This is where I looked at:
http://rust-lang.github.io/book/

@carols10cents
Copy link
Member

Yeah that CSS comes from mdBook, so it would need to be fixed over there.

@StefanoD
Copy link
Author

Ok, thx. I opened an issue on mdBook.
https://github.com/azerupi/mdBook/issues/203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants