Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple lints incorrectly not included with unused lint group #42172

Closed
sanmai-NL opened this issue May 23, 2017 · 3 comments
Closed

Multiple lints incorrectly not included with unused lint group #42172

sanmai-NL opened this issue May 23, 2017 · 3 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@sanmai-NL
Copy link

In rustc 1.19.0-nightly (01951a61a 2017-05-20), and reproducible.

@sanmai-NL
Copy link
Author

In #30849 @alexcrichton wrote this lint has been allow by default. Based on a short survey of this issue tracker and that issue in particular, I think there's no reason left to leave it at allow instead of warn.

@sanmai-NL
Copy link
Author

sanmai-NL commented May 23, 2017

Same issue for the unused-features lint.

I don't know if rustc -W help is reliable, but it does not list the two ‘sub-lints’ there (same rustc version):

Lint groups provided by rustc:

                   name  sub-lints
                   ----  ---------
               warnings  all built-in lints
              bad-style  non-camel-case-types, non-snake-case, non-upper-case-globals
    future-incompatible  private-in-public, inaccessible-extern-crate, invalid-type-param-default, super-or-self-in-global-path, illegal-floating-point-constant-pattern, illegal-floating-point-literal-pattern, illegal-struct-or-enum-constant-pattern, hr-lifetime-in-assoc-type, lifetime-underscore, resolve-trait-on-defaulted-unit, safe-extern-statics, patterns-in-fns-without-body, extra-requirement-in-impl, legacy-directory-ownership, legacy-imports, legacy-constructor-visibility, missing-fragment-specifier, anonymous-parameters
                 unused  unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros

@sanmai-NL sanmai-NL changed the title unused-extern-crates lint not included with unused lint group Multiple lints incorrectly not included with unused lint group May 23, 2017
@Mark-Simulacrum Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 23, 2017
@Mark-Simulacrum Mark-Simulacrum added C-bug Category: This is a bug. A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. labels Jul 27, 2017
@JohnTitor
Copy link
Member

Triage: The unused lint group now contains unused_extern_crates and unused_features.

Lint groups provided by rustc:

name  sub-lints
----  ---------
unused  unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, overlapping-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants