Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magnet_app-0.0.1 beta regression because of diesel #43672

Closed
est31 opened this issue Aug 5, 2017 · 2 comments
Closed

magnet_app-0.0.1 beta regression because of diesel #43672

est31 opened this issue Aug 5, 2017 · 2 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

magnet_app version 0.0.1 regressed from stable to beta because it depends on diesel 0.7.1 and diesel broke (full log):

Aug 03 09:39:48.109 INFO kablam! error: unexpected end of macro invocation
Aug 03 09:39:48.109 INFO kablam!   --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/diesel-0.7.1/src/connection/mod.rs:49:9
Aug 03 09:39:48.109 INFO kablam!    |
Aug 03 09:39:48.109 INFO kablam! 49 |         assert_eq!(self.get_transaction_depth(), 0);
Aug 03 09:39:48.109 INFO kablam!    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Aug 03 09:39:48.109 INFO kablam!    |
Aug 03 09:39:48.109 INFO kablam!    = note: this error originates in a macro outside of the current crate

cc @stefanoc
@arielb1 arielb1 added I-nominated regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

Looks like there's a column macro in https://github.com/diesel-rs/diesel/blob/v0.7.1/diesel/src/macros/mod.rs. Duplicate of #43057.

@arielb1 arielb1 closed this as completed Aug 5, 2017
@arielb1 arielb1 reopened this Aug 5, 2017
@arielb1 arielb1 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@arielb1 arielb1 mentioned this issue Aug 5, 2017
Closed
@alexcrichton
Copy link
Member

Fixed in #43735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @arielb1 @est31