Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20% compiler memory usage regression in syntex_syntax incremental compile #43835

Closed
alexcrichton opened this issue Aug 13, 2017 · 2 comments
Closed

20% compiler memory usage regression in syntex_syntax incremental compile #43835

alexcrichton opened this issue Aug 13, 2017 · 2 comments
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

According to perf.rust-lang.org the syntex_syntax benchmark for a clean incremental compile regressed 20% in compiler memory usage due to #43028.

@michaelwoerister is it helpful to track "regressions" for incremental compilation right now? Or is enough in flux that we should not worry about it just yet?
@alexcrichton alexcrichton added I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Aug 13, 2017
@michaelwoerister
Copy link
Member

I'd say, not quite yet as there are some big changes around the corner. Also, I'm not sure how reliable perf.rlo is for anything after #43506. (@Mark-Simulacrum would know more about the current state there).

@alexcrichton
Copy link
Member Author

Ok sounds like we shouldn't track incremental-related regressions yet, so I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. I-compilemem Issue: Problems and improvements with respect to memory usage during compilation. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @michaelwoerister @Mark-Simulacrum