Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enormous perf.rlo regression from a single commit on September 18 #44719

Closed
bstrie opened this issue Sep 20, 2017 · 3 comments
Closed

Enormous perf.rlo regression from a single commit on September 18 #44719

bstrie opened this issue Sep 20, 2017 · 3 comments
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bstrie
Copy link
Contributor

bstrie commented Sep 20, 2017

perf.rust-lang.org is showing a huge regression. Syntex regressed by 100%, while about eight others regressed by 10% to 50%. Mousing over the graph, the commit that exhibits this regression is 0701b37 , which is difficult to immediately diagnose as it's a rollup.
@bstrie bstrie added the I-compiletime Issue: Problems and improvements with respect to compile times. label Sep 20, 2017
@Mark-Simulacrum
Copy link
Member

cc @rust-lang/compiler: Nominating for assignment.

@Mark-Simulacrum Mark-Simulacrum added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2017
@eddyb
Copy link
Member

eddyb commented Sep 20, 2017 •
edited
Loading

Looking at the PR list, #44364 seems likely, cc @michaelwoerister @nikomatsakis @alexcrichton

@alexcrichton
Copy link
Member

This was discussed on the PR and concluded as "no action needed", so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @eddyb @bstrie @Mark-Simulacrum