Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: integrate a proper warning/error handler #46844

Closed
QuietMisdreavus opened this issue Dec 19, 2017 · 2 comments
Closed

rustdoc: integrate a proper warning/error handler #46844

QuietMisdreavus opened this issue Dec 19, 2017 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@QuietMisdreavus
Copy link
Member

QuietMisdreavus commented Dec 19, 2017

The current markdown rendering warnings are just a collection of println!() statements. It would be worthwhile to create a rustc_errors::Handler for rustdoc to properly emit errors from, so that these and others can be given proper formatting, and possibly even a mini lint system, or at least being able toggle specific errors between allow/warn/err.

@QuietMisdreavus QuietMisdreavus added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 19, 2017
@euclio
Copy link
Contributor

euclio commented Feb 13, 2019

I think this is fixed, no?

@QuietMisdreavus
Copy link
Member Author

Indeed it is! We've started using a diagnostic emitter from rustc_errors, and all our errors and warnings go through that mechanism now. I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants