Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc_macro::SourceFile::path() returns a non-public type #47077

Closed
mystor opened this issue Dec 30, 2017 · 3 comments
Closed

proc_macro::SourceFile::path() returns a non-public type #47077

mystor opened this issue Dec 30, 2017 · 3 comments
Labels
A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@mystor
Copy link
Contributor

mystor commented Dec 30, 2017

This function currently returns a syntax_pos::FileName, which is not exported from the proc_macro crate.

A good solution may be to export a struct FileName(syntax_pos::FileName) object which implements Display.

cc @jseyfried
@mystor mystor mentioned this issue Dec 30, 2017
Merged
@pietroalbini pietroalbini added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-macros-2.0 Area: Declarative macros 2.0 (#39412) labels Jan 30, 2018
@dtolnay
Copy link
Member

dtolnay commented Apr 29, 2018

Still a problem. proc_macro::SourceFile::path

@abonander
Copy link
Contributor

Caused by d732da8

@inquisitivecrystal
Copy link
Contributor

I believe that this was fixed by #52552.

@dtolnay dtolnay closed this as completed Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mystor @dtolnay @pietroalbini @abonander @inquisitivecrystal