Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incr.comp.: Investigate making the result cache updateable in-place. #48231

Open
michaelwoerister opened this issue Feb 15, 2018 · 0 comments
Open
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

Right now the compiler will always load and deserialize all query result cache entries that are still valid and then serialize and write them to back to disk again, similar to how a copying garbage collector works. The main reason for implementing the cache this way is that it is very simple.

There might be value in making the cache file updateable in-place in order to save serialization time for unchanged entries. First though, we need some profiling evidence that this would actually save a noticeable amount of time.

@michaelwoerister michaelwoerister added the A-incr-comp Area: Incremental compilation label Feb 15, 2018
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2018
@jonas-schievink jonas-schievink added the I-compiletime Issue: Problems and improvements with respect to compile times. label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants