Skip to content

Tracking issue for the unreachable_pub compatibility lint #48721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manishearth opened this issue Mar 4, 2018 · 5 comments
Closed

Tracking issue for the unreachable_pub compatibility lint #48721

Manishearth opened this issue Mar 4, 2018 · 5 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC WG-epoch Working group: Epoch (2018) management

Comments

@Manishearth
Copy link
Member

Manishearth commented Mar 4, 2018

In Rust 2018, we will deprecate code that is pub but not crate-reachable, requiring pub(crate) instead.

If you see this warning, just replace the relevant line with pub(crate)

@Manishearth Manishearth added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Mar 4, 2018
@zackmdavis
Copy link
Member

Does this just mean that the unreachable-pub lint will become default-Warn (it's currently default-Allow), or is something stronger intended?

Is stabilization of the crate visibility modifier (synonymous to pub(crate)) potentially relevant here? (The lint will already suggest crate or pub(crate) depending on the crate_visibility_modifier feature flag, but if "non-crate-reachable code isn't pub" is something to teach/sell as part of "Rust 2018", maybe the new keyword use is, too.)

@zackmdavis
Copy link
Member

There is one outstanding bug report for the lint: #47816

@Manishearth
Copy link
Member Author

I'm not sure. I think it will be allow for now but may become warn later, regardless of the epoch you're on. @withoutboats may know.

I filed this issue so the lint can be marked an epoch-related lint (you need a tracking issue), there's not much more to infer from that.

@withoutboats
Copy link
Contributor

I think it will be allow for now but may become warn later, regardless of the epoch you're on. @withoutboats may know.

We're not sure.

@Manishearth Manishearth added the WG-epoch Working group: Epoch (2018) management label Mar 6, 2018
@Manishearth
Copy link
Member Author

This lint isn't actually a future compat lint, closing the tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC WG-epoch Working group: Epoch (2018) management
Projects
None yet
Development

No branches or pull requests

3 participants