-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http
crate does not compile against latest nightly (caused by TryFrom
).
#49436
Comments
I replied to @sfackler in the issue linked above, but I thought it would be worth posting here: My understanding was that these sorts of "expected breakage" would go through an ecosystem "crater" (or whatever it is called) and if it broke things it wouldn't be applied. I understand the problem that one must be able to add new fns / traits, but if breaking the The "fix" seems to be to not include |
It does seem like adding new traits to the prelude with a generic name like that should be reserved for new editions. I'd suggest that the real solution is to have the compiler resolve the conflict by ranking explicit trait imports as higher than traits in a prelude (I guess any glob import). |
There's a fair bit of discussion going on on this topic in the stabilization PR. |
Since we've reverted TryFrom stabilization entirely and I believe this is no longer a problem, I'm going to close this. |
See here: hyperium/http#192
try_from
is already defined on on anHttpTryFrom
trait in the library.This is caused by
TryFrom
being included inprelude
.The text was updated successfully, but these errors were encountered: