Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potentially missing items from rust_2018_edition feature gate #50443

Closed
7 tasks
nikomatsakis opened this issue May 4, 2018 · 1 comment
Closed
7 tasks

potentially missing items from rust_2018_edition feature gate #50443

nikomatsakis opened this issue May 4, 2018 · 1 comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

I noticed recently some feature gates that rust_2018_edition does not enable that I think it should:

  • #![feature(catch_expr)]
  • #![feature(crate_in_paths)]
  • #![feature(crate_visibility_modifier)]
  • #![feature(extern_absolute_paths)]
  • #![feature(proc_macro)]
  • #![feature(in_band_lifetimes)]
  • #![feature(termination_trait_test)]

cc @Manishearth

@nikomatsakis nikomatsakis added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 4, 2018
@Manishearth
Copy link
Member

Most of these features seem to be enabled already? It's rust_2018_preview. It's only catch_expr and proc_macro that aren't.

@bors bors closed this as completed in 7485903 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants