Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nll] do a crater run with NLL enabled, track results #51827

Closed
nikomatsakis opened this issue Jun 26, 2018 · 4 comments
Closed

[nll] do a crater run with NLL enabled, track results #51827

nikomatsakis opened this issue Jun 26, 2018 · 4 comments
Labels
A-NLL Area: Non-lexical lifetimes (NLL) NLL-complete Working towards the "valid code works" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Rust 2018 Preview 2

Comments

@nikomatsakis
Copy link
Contributor

It'd be good for us to do a crater run with NLL enabled by default and try to track the results. One problem is that it's not clear if the compiler will bootstrap with NLL enabled (#51823). In order to disconnect these two questions, we came up with the following strategy in a brief IRC discussion:

  • Make a build of rustc where -Zborrowck=mir is the default but only if the RUSTC_BOOTSTRAP environment variable is not set.
  • Open a [WIP] PR with this branch and do a crater run.

After some discussion on IRC, w
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-compiler-nll NLL-complete Working towards the "valid code works" goal labels Jun 26, 2018
@nikomatsakis
Copy link
Contributor Author

Zulip thread can be found here

@nikomatsakis nikomatsakis added this to the Rust 2018 Preview 2 milestone Jun 29, 2018
@Mark-Simulacrum Mark-Simulacrum self-assigned this Jul 1, 2018
@Mark-Simulacrum
Copy link
Member

We've started a crater run with ef9a322, this run is master vs. master with -Zborrowck=mir on one. Results should be available in around ~3 days.

@Mark-Simulacrum
Copy link
Member

@lqd is working through the two crater runs we've done so far. It also turned out that we should enable -Ztwo-phase-borrows as well; we've now done so. This is the latest crater run: https://cargobomb-reports.s3.amazonaws.com/nll-3/index.html.

@Mark-Simulacrum Mark-Simulacrum removed their assignment Jul 7, 2018
@nikomatsakis nikomatsakis added the A-NLL Area: Non-lexical lifetimes (NLL) label Jul 17, 2018
@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Jul 17, 2018 •
edited
Loading

This has been done. @lqd and @Mark-Simulacrum are :superheros:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-NLL Area: Non-lexical lifetimes (NLL) NLL-complete Working towards the "valid code works" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
Rust 2018 Preview 2
Development

No branches or pull requests
2 participants
@nikomatsakis @Mark-Simulacrum