Skip to content

pub use serde::* doesn't show traits in cargo doc #53724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KamilaBorowska opened this issue Aug 26, 2018 · 2 comments
Open

pub use serde::* doesn't show traits in cargo doc #53724

KamilaBorowska opened this issue Aug 26, 2018 · 2 comments
Labels
C-bug Category: This is a bug. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@KamilaBorowska
Copy link
Contributor

This is somewhat weird, but on https://konradborowski.gitlab.io/serde-feature-hack/serde_feature_hack/index.html, I don't see traits like Serialize, even if they should be here, and there is no note of re-export either. On https://docs.rs/serde-feature-hack/0.1.0/serde_feature_hack/, it shows a re-export, so this appears to be a regression.

The code:

extern crate serde;
pub use serde::*;
@Havvy Havvy added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 27, 2018
@QuietMisdreavus
Copy link
Member

In #51584, i made it so that glob re-exports were properly inlined by rustdoc. However, it seems that when inlining a module from another crate (or in this case, the crate root), it doesn't see any re-exports that happen to be in that module.

Note that on the docs.rs version (using an older rustdoc), it's showing the re-export for serde itself, not for anything within it. You could try forcing this by adding #[doc(no_inline)] to the re-export, but otherwise this should be investigated.

@jyn514 jyn514 added the C-bug Category: This is a bug. label Aug 25, 2020
@lolbinarycat lolbinarycat added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Nov 15, 2024
@lolbinarycat
Copy link
Contributor

triage: has been fixed, needs regression test (glob reexport of glob reexport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants