Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-44056.rs was incorrectly moved to compile pass and should not if hardware does not support AVX #55996

Open
gnzlbg opened this issue Nov 16, 2018 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 16, 2018

See #55667.

There are two problems:

  • the issue-44056.rs test was incorrectly moved from run-pass (Compiled executable fails to launch when built with AVX and LTO enabled #44056) to compile-pass: this test must be executed

  • the issue-44056.rs test should not run on non-AVX hardware, and this cannot be checked in the test itself. That is, the test runner has to detect whether the host supports AVX, and then and only then, attempt to run the test.

cc @infinity0 @RalfJung @nikic @alexcrichton

@gnzlbg gnzlbg changed the title issue-44056.rs was incorrectly moved to compile pass and should not if hardware does not support AVX2 issue-44056.rs was incorrectly moved to compile pass and should not if hardware does not support AVX Nov 16, 2018
@RalfJung
Copy link
Member

the issue-44056.rs test should not run on non-AVX hardware, and this cannot be checked in the test itself. That is, the test runner has to detect whether the host supports AVX, and then and only then, attempt to run the test.

Alternatively, the actual test could be in an auxiliary file that is executed by the main test via std::process. There are some other tests that do this, e.g. for a test that aborts the process to check that the right signal is raised.

@jonas-schievink jonas-schievink added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 27, 2019
@JohnTitor JohnTitor added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 12, 2020
@Enselic
Copy link
Member

Enselic commented Dec 12, 2023

Triage: Marking as E-help-wanted since it is clear we want help with this.

@Enselic Enselic added the E-help-wanted Call for participation: Help is requested to fix this issue. label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants