Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta regression: svgdom struct is private #56317

Closed
alexcrichton opened this issue Nov 28, 2018 · 3 comments
Closed

beta regression: svgdom struct is private #56317

alexcrichton opened this issue Nov 28, 2018 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Discovered by crater:

$ git clone https://github.com/RazrFalcon/resvg
$ cd resvg
$ git reset --hard v0.3.0
$ cargo +beta build

cc @petrochenkov

@alexcrichton alexcrichton added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Nov 28, 2018
@alexcrichton alexcrichton added this to the Rust 2018 Release milestone Nov 28, 2018
@petrochenkov
Copy link
Contributor

This is an expected bug-fix regression, it was previously found by the crater run in #55884 as well.
It has a dedicated test - https://github.com/rust-lang/rust/blob/master/src/test/ui/imports/issue-55884-2.rs.

@alexcrichton
Copy link
Member Author

👍

cc @RazrFalcon, just to make sure you're aware!

@RazrFalcon
Copy link

Thanks. Not sure how this should be fixed. It actually works in master, but not in v0.13. And I wan't to make v0.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants