Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't catch total tools breakage #57398

Closed
o01eg opened this issue Jan 7, 2019 · 1 comment
Closed

CI doesn't catch total tools breakage #57398

o01eg opened this issue Jan 7, 2019 · 1 comment
Labels
T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@o01eg
Copy link
Contributor

o01eg commented Jan 7, 2019

PR #57101 introduced changes cause all tools to fail tests.

Should CI have test for common tools usages such as searching and loading codegen dynamic libraries and searching std rust libraries?

@o01eg o01eg changed the title CI don't catch total tools breakage CI doesn't catch total tools breakage Jan 7, 2019
@oli-obk oli-obk added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label Jan 7, 2019
@ehuss
Copy link
Contributor

ehuss commented Feb 15, 2022

I'm going to close this as I don't think there is anything particularly actionable here.

When #57101 landed, the other tools were already in the "broken" state. There would be no way to check for the failure when they were already failing. Also, it did detect that miri failed.

Nowadays, clippy is in-tree and its tests are now required to pass, so that should detect this particular problem. RLS will eventually go away, so that just leaves miri as a potentially breakable tool, and that is handled differently (nightly only, has a cron job, etc.)

@ehuss ehuss closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants