Skip to content

Add compile_warning! builtin macro #57751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kampfkarren opened this issue Jan 19, 2019 · 1 comment
Closed

Add compile_warning! builtin macro #57751

Kampfkarren opened this issue Jan 19, 2019 · 1 comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Kampfkarren
Copy link
Contributor

Kampfkarren commented Jan 19, 2019 •
edited
Loading

compile_error! was added in 1.20, about a year and a half ago. This has proven to be a useful feature to me, however I was confused about the absence of a warning equivalent. I can think of times where it may be useful to warn instead of error, eg expecting certain cfgs to be enabled when compiling, or for macros to use for weird behavior.

I'm not sure if this is a large enough request to where it would warrant an RFC, but I don't think so?
@memoryruins memoryruins added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Jan 19, 2019
@Kampfkarren
Copy link
Contributor Author

After reading the oversights brought up by rust-lang/rfcs#1695 (comment), I'm going to close this in favor of an RFC.

@kennytm kennytm mentioned this issue Apr 7, 2020
Open
@clarfonthey clarfonthey mentioned this issue May 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kampfkarren @memoryruins