Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run-pass checks for warnings, notes, etc. #59659

Open
Centril opened this issue Apr 3, 2019 · 3 comments
Open

Run-pass checks for warnings, notes, etc. #59659

Centril opened this issue Apr 3, 2019 · 3 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Apr 3, 2019

When writing #59658, I found it neccesary to check for warnings in a run-pass test because deny(warning) would observably change the warning pattern I was testing for in the first place.

It would be nice if run-pass would check for WARN, NOTE, HELP, etc. and cause a test failure if those are not found when expected. A bonus point for failing for unexpected WARNs etc. as well.
@Centril Centril added A-testsuite Area: The testsuite used to check the correctness of rustc A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2019
@petrochenkov
Copy link
Contributor

Looks similar to #56277.

@Centril Centril mentioned this issue Apr 8, 2019
Closed
@lcnr
Copy link
Contributor

lcnr commented Apr 26, 2020

Is this still relevant? Afaict run-pass tests have been moved to ui

@petrochenkov
Copy link
Contributor

Is this still relevant?

Probably not, but someone needs to check that there's no gratuitous differences between // run-pass UI tests and other UI tests with regards to WARN, NOTE and HELP annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Centril @petrochenkov @lcnr