Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy doesn't check for unused extern crates #62036

Open
Mark-Simulacrum opened this issue Jun 21, 2019 · 0 comments
Open

Tidy doesn't check for unused extern crates #62036

Mark-Simulacrum opened this issue Jun 21, 2019 · 0 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Mark-Simulacrum
Copy link
Member

Since 44a01b8, tidy no longer emits unused crate warnings -- i.e., Cargo.toml has a dependency but the associated library does not. Due to use of 2018 edition implicit imports, this is no longer an easy thing to do (any file within the crate can use the crate, and extern crate isn't required).

I'm thinking we can probably just remove this tidy lint for now in favor of something like #57274 in the future.

@Mark-Simulacrum Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 21, 2019
@Enselic Enselic added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants