Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the comment re. unstable-book in src/libsyntax/feature_gate/active.rs still relevant? #63840

Closed
Centril opened this issue Aug 24, 2019 · 2 comments
Closed

Is the comment re. unstable-book in src/libsyntax/feature_gate/active.rs still relevant? #63840

Centril opened this issue Aug 24, 2019 · 2 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Aug 24, 2019

See #63824 (comment).

The comment currently exists in src/libsyntax/feature_gate.rs but is being moved in the PR above to src/libsyntax/feature_gate/active.rs.

cc @oli-obk
@Centril Centril added I-needs-decision Issue: In need of a decision. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Aug 24, 2019
@Centril Centril mentioned this issue Aug 24, 2019
Merged
@est31
Copy link
Member

est31 commented Aug 24, 2019

unstable-book-gen at least uses tidy which seems to have been updated by 3cfb6bc

So any autogenerated unstable book page won't need any updates. Any non-autogenerated page will need one though as the tracking issue is hardcoded there. Changes that aren't detected automatically are for example when the tracking issue changes and the entry in the book is not updated. When the feature stabilizes, there is a tidy error though. So yes, active is a good place for that comment.

@Centril
Copy link
Contributor Author

Centril commented Sep 8, 2019

@oli-obk Seems the answer is "yes". I'll close this for now.

@Centril Centril closed this as completed Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools I-needs-decision Issue: In need of a decision. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Centril @est31