Intra-rustdoc links do not work for unqualified names in doc for a trait impl method

[mzabaluev]

There may be a problem with using intra-rustdoc links (#43466) in doc for a method implementation in a trait impl item. This fixup had to be made because an unqualified link to the Policy trait that is declared into the same module was rendered as [Policy] without the link. Other unqualified links to Policy in documentation elsewhere in the same module work as expected.

Meta

rustc --version --verbose:
rustc 1.41.0-nightly (5c5b8af 2019-11-16)
binary: rustc
commit-hash: 5c5b8af
commit-date: 2019-11-16
host: x86_64-unknown-linux-gnu
release: 1.41.0-nightly

[ghost]

Perhaps related to #54172

[ghost]

@mzabaluev is this duplicate of #54172 ?
If so we could close it.

[mzabaluev]

@mzabaluev is this duplicate of #54172 ?

No, that issue is about links to a specific impl method. Here, the link is to an unqualified trait name, but it is located in the doc of an impl method of a different trait, which somehow breaks it.

[ghost]

unqualified trait name

What is an unqualified trait name? Could you give an example of it?
Sorry i couldn't find anything suitable for it.

I only found fully-qualified term here
https://doc.rust-lang.org/book/ch19-03-advanced-traits.html?search=#fully-qualified-syntax-for-disambiguation-calling-methods-with-the-same-name

[mzabaluev]

@xliiv Here's a minimized test case:

use std::fmt;

pub trait Pretty {
    fn to_pretty(&self) -> String;
}

pub struct Ooh<T>(T);

impl<T: Pretty> fmt::Display for Ooh<T> {
    /// Uses [`Pretty`] to format the inner object.
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        f.write_str(&self.0.to_pretty())
    }
}

It works in nightly, so I assume it is fixed.

[ghost]

Great news!