Skip to content

match arms have incompatible types #66516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mark-Simulacrum opened this issue Nov 18, 2019 · 2 comments
Closed

match arms have incompatible types #66516

Mark-Simulacrum opened this issue Nov 18, 2019 · 2 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/HristoKolev.sync-dir/log.txt

Possibly due to flatten getting stabilized or something like that, need to investigate further.

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Nov 18, 2019
@ecstatic-morse
Copy link
Contributor

1.37.0-stable gives the following warning when building this crate:

warning: a method with this name may be added to the standard library in the future
   --> src/global/extensions.rs:132:26
    |
132 |             Some(v) => v.flatten(),
    |                          ^^^^^^^
    |
    = note: #[warn(unstable_name_collisions)] on by default
    = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior!
    = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
    = help: call with fully qualified syntax `global::extensions::OptionFlatten::flatten(...)` to keep using the current method

It seems this is allowed breakage and we should maybe ping the author?

@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 19, 2019
@Mark-Simulacrum
Copy link
Member Author

Makes sense to me. cc @HristoKolev -- this is likely to be closed as accepted breakage, so you'll likely want to update your crate/repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants