NLL Regressions in 1.40

[Mark-Simulacrum]

• thrussh: point release needed with a fix: 0.19.6; broken
• vek: verify that more recent versions build, 0.9.4 is broken
• florima/agents: fix master, broken
• https://github.com/johshoff/find-tempo-rust-backend: https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/johshoff.find-tempo-rust-backend/log.txt
• https://github.com/mfontanini/rpki-validator: https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/mfontanini.rpki-validator/log.txt
• https://github.com/fernandobatels/blitz-money: https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/fernandobatels.blitz-money/log.txt

root: capnp - 4 (1 gh, 3 crates.io) detected crates which regressed due to this:

• capnp-gj-0.2.1: start v. end
• leaf-0.2.1: start v. end
• rotor-capnp-0.1.0: start v. end
• dmichiels/temp_rustfbp: start v. end

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/chiisai-0.1.6/log.txt

root: epub - 4 (2 gh, 2 crates.io) detected crates which regressed due to this

• epub-1.2.0: start v. end
• mdbook-epub-0.3.0: start v. end
• Michael-F-Bryan/mdbook-epub: start v. end
• cthwaite/pulp: start v. end

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/tigertoes.fe2o3/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/AuroransSolis.fractions_and_matrices/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/galvanize-0.0.1/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/remram44.vigilant-steel/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/genco-0.3.30/log.txt

root: gfx-hal - 4 (2 gh, 2 crates.io) detected crates which regressed due to this

• bvh_anim-0.4.0: start v. end
• imagine-0.0.1: start v. end
• lcnr/wgpu_err: start v. end
• vitvakatu/cubes: start v. end

root: gltf - 10 (6 gh, 4 crates.io) detected crates which regressed due to this:

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/gltf-importer-0.10.1/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/osprey-0.4.4/log.txt

root: gstreamer - 3 (3 gh, 0 crates.io) detected crates which regressed due to this

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/man0lis.ascii-star/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/hpack_codec-0.1.0/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/Gopiandcode.html_gen/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/ilp-packet-0.3.0/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/crazymerlyn.kilo-rs/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/ethowitz.life/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/liner-0.4.4/log.txt

root: liquid-value - 6 (4 gh, 2 crates.io) detected crates which regressed due to this

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/amethyst_tools-0.9.0/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/nero-0.0.1/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/sarahlim.parcheesi/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/quickercheck-0.2.0/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/rental-0.5.5/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/koba-e964.rust-number-theory/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/SpinResearch.RustySecrets/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/SiegeEngine.siege-example-client/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/smoltcp-0.5.0/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/c7x43t.hello_cargo2/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/cucumber-0.3.1/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/Askannz.icosphere/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/espota-server-0.3.0/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/alexjeffries.yams/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/leguichet-0.1.8/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/reg/redox_pkgutils-0.1.3/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/RustyVolley.RustyVolleySrc/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/achankf.game-project/log.txt

• https://crater-reports.s3.amazonaws.com/beta-1.40-1/beta-2019-11-06/gh/u59u75u65.lihkgbox-rs/log.txt

[Centril]

Is there anything actionable here?

[Mark-Simulacrum]

I am hopeful that we can patch crates on crates.io at least, ideally we'd go out and fix all of the above (i.e., PRs, or better yet releases where applicable) in time for the release.

[pnkfelix]

triage: P-high

[pnkfelix]

nominating for discussion at triage meeting, to see if we can get a subset of developers to divvy up the work here.

[lqd]

I took a look at

1. chiisai-0.1.6: the repository has been archived
2. the capnp root:

• capnp-gj-0.2.1, depends on capnp-0.7.5: the repository was marked deprecated in 2017
• leaf-0.2.1, depends on capnp-0.6.2: the project has been abandoned in 2016
• rotor-capnp-0.1.0, depends on capnp-0.6.2: the repository looks inactive since 2016
• dmichiels.temp_rustfbp, depends on capnp-0.7.5: the repository looks like a test, inactive since 2016

3. the gfx-hal root:

• bvh_anim-0.4.0, depends on gfx-hal-0.1.0 via wgpu-0.2.3: master has since been fixed when it removed the dependency, but updating to wgpu-0.3.0 also makes it build (probably because it's not actually used as a dependency)
• imagine-0.0.1, depends on gfx-hal-0.1.0: a temporary "squatting" release, which builds with e.g. gfx-hal-0.2.0
• lcnr/wgpu_err, depends on gfx-hal-0.1.0 via wgpu-0.2.3: the single commit repository mentions it's only a test -- but is otherwise in the same boat as the next one
• vitvakatu/cubes, depends on gfx-hal-0.1.0 via wgpu-0.2.2: seems like a port of a demo, last commit 8 months ago -- note that wgpu-0.3.0's gfx-hal version builds, but is itself incompatible with wgpu-0.2, so maybe we could somehow bump gfx-hal in another wgpu-0.2 release ?

Here's a hackmd for easier coordination, at the very least to filter out the inactive crates.

[pnkfelix]

discussed this in last week's T-compiler meeting.

Removing nomination and self-assigning to push through remainder of review.

[Mark-Simulacrum]

I think I actually finished most of the bullets in the hackmd, mostly concluding that there's no need to take any particular action. I believe there's a few unchecked bullets left that probably warrant some deeper investigation (perhaps a PR).

[lqd]

As another update, there was also coordination in this zulip thread.

We've gone over the list, sent a few PRs where we could (many thanks to @djc for helping with this as well), and it seems like we're in an OK place.

[lqd]

also, many thanks to @P-E-Meunier for publishing the semver-compatible updates 0.19.6 and 0.20.8 to thrussh 🎉

[Mark-Simulacrum]

I believe we are now ready to close this issue, deeming the rest of the regressions as either won't fix (due to the crate/repository in question being deprecated or otherwise unmaintained) or fixable via cargo update (and we don't have the resources to send hundreds of PRs doing so).