Skip to content

macro export shadowing/duplicate #67608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mark-Simulacrum opened this issue Dec 25, 2019 · 1 comment
Closed

macro export shadowing/duplicate #67608

Mark-Simulacrum opened this issue Dec 25, 2019 · 1 comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

root: fixed-hash - 4 (4 gh, 0 crates.io) detected crates which regressed due to this

  • CodeChain-io/codechain-blake-miner: start v. end
  • CodeChain-io/codechain-cuckoo-miner: start v. end
  • NervosFoundation/serde_bench: start v. end
  • TheWaWaR/cita-create-genesis: start v. end

root: lsio - 2 (0 gh, 2 crates.io) detected crates which regressed due to this

cc @petrochenkov

cc #49084 (though not directly relevant)

I suspect this is a semi-intentional change.

These crates also fail, but with shadowing of built-ins; I suspect this is the same bug:

  • root: conniecs-0.2.0: start v. end

  • root: lightning-wire-msgs-0.2.1: start v. end

root: lime-render - 2 (1 gh, 1 crates.io) detected crates which regressed due to this

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 25, 2019
@Centril
Copy link
Contributor

Centril commented Dec 25, 2019

Intentionally made an error in 8e27c4f.

@Centril Centril closed this as completed Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants