Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#68047 #68068

Closed
rust-highfive opened this issue Jan 9, 2020 · 4 comments
Closed

rls no longer builds after rust-lang/rust#68047 #68068

rust-highfive opened this issue Jan 9, 2020 · 4 comments
Assignees
@Xanewok
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #68047, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @pietroalbini, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Mark-Simulacrum, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2020
@pietroalbini
Copy link
Member

Well, I just fixed toolstate 😅

@pnkfelix
Copy link
Member

T-compiler triage: P-medium, removing nomination label.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jan 16, 2020
@jplatte
Copy link
Contributor

jplatte commented Jan 16, 2020

Fixed in #68254 it seems :)

@Xanewok
Copy link
Member

Xanewok commented Jan 16, 2020

That's true :) As per https://rust-lang-nursery.github.io/rust-toolstate/

@Xanewok Xanewok closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pnkfelix @jplatte @pietroalbini @Xanewok @rust-highfive