Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#68861 #68878

Closed
rust-highfive opened this issue Feb 6, 2020 · 2 comments · Fixed by #68930
Closed

miri no longer builds after rust-lang/rust#68861 #68878

rust-highfive opened this issue Feb 6, 2020 · 2 comments · Fixed by #68930
Assignees
@eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #68861, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Dylan-DPC, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 6, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Feb 6, 2020

triage: P-medium, removing nomination tag.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Feb 6, 2020
@RalfJung
Copy link
Member

RalfJung commented Feb 6, 2020

Already fixed on the Miri side: rust-lang/miri#1168

@RalfJung RalfJung mentioned this issue Feb 7, 2020
Merged
@bors bors closed this as completed in fb29dfc Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update miri RalfJung/rust
5 participants
@eddyb @pnkfelix @RalfJung @oli-obk @rust-highfive