Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty serious perf regressions in opt benchmarks #71261

Closed
ljedrz opened this issue Apr 17, 2020 · 3 comments
Closed

Pretty serious perf regressions in opt benchmarks #71261

ljedrz opened this issue Apr 17, 2020 · 3 comments
Labels
C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ljedrz
Copy link
Contributor

ljedrz commented Apr 17, 2020 •
edited
Loading

It appears that one of the changes today caused serious regressions in some of the opt benches, mostly patched incremental:

regex-opt        | avg: 61.3% | min: -0.0% | max: 330.1%
webrender-opt    | avg: 78.2% | min: -0.0% | max: 312.6%
piston-image-opt | avg: 73.3% | min: -0.4% | max: 293.4%
ripgrep-opt      | avg: 31.3% | min: -0.1% | max: 125.3%
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2020
@Mark-Simulacrum
Copy link
Member

868b51b...b2c1a60 is the commit range, but I think this is #71248? (That at least seems logical to me).

We should have perf results soonish as they populate in...

@ljedrz
Copy link
Contributor Author

ljedrz commented Apr 17, 2020

Yes, seems to be the same thing; feel free to close this issue once it's confirmed, I seem to have missed the previous one 😛 .

@jonas-schievink
Copy link
Contributor

New commit range: 868b51b...318726b

Updated perf: https://perf.rust-lang.org/compare.html?start=868b51be6f29d5b43d37c5d65bac1482d3a50ad8&end=318726b301db2a0718d05f166d3d6c578273189c&stat=instructions:u

Closing in favor of #71248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas-schievink @ljedrz @Mark-Simulacrum