Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy is not installed to destination dir if 'tools' config variable not explicitly defined. #72171

Open
ebeasant-arm opened this issue May 13, 2020 · 9 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ebeasant-arm
Copy link

ebeasant-arm commented May 13, 2020

Found whilst performing a extended tools release bootstrap build on aarch64:

Unless 'tools' is explicitly specified in config.toml with an extended build config, clippy is not installed, it is explicitly skipped as it does not appear in builder.config.tools (src/install.rs, Line: Line: 158, Line: 222)
Clippy is actually built for stage 2, but not installed by install.py.
Of the default extended tools built when extended-tools are enabled, only clippy seems to behave like this.

If this is intended behaviour, then a note in the config.toml indicating this would be helpful :-)

This occurs using the default channel (dev) in config.toml, constructed only using ./configure --enable-full-tools --prefix=$RUST_TOOLCHAIN_DIR --sysconfdir=$RUST_TOOLCHAIN_DIR on aarch64 native host.

@Mark-Simulacrum
Copy link
Member

cc @oli-obk probably fallout from the subtree migration

@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 13, 2020
@imogenkinsman
Copy link
Contributor

I can investigate this if that's okay - would be a good way for me to familiarize myself with rust's build system.

@imogenkinsman
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this May 15, 2020
@imogenkinsman
Copy link
Contributor

I can't verify this issue on master until #72231 is resolved, as that's blocking extended tools builds.

@mati865
Copy link
Contributor

mati865 commented May 18, 2020

@jademcgough you can use missing-tools or tools config.toml options.

@imogenkinsman
Copy link
Contributor

imogenkinsman commented May 29, 2020

@mati865 Thanks! missing-tools was perfect for unblocking me.

Traced it to regression caused by a182450. Should have a fix for this tomorrow.

@Alexendoo
Copy link
Member

Triage: Hi, are you still working on this issue @immykins?

@Alexendoo
Copy link
Member

@rustbot release-assignment

@rustbot rustbot removed their assignment Aug 26, 2020
@Enselic
Copy link
Member

Enselic commented Dec 16, 2023

Triage: Is this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

7 participants