Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.45.0 aarch64-apple-ios generates multiple messages: "'+cyclone' is not a recognized feature for this target (ignoring feature)" #74427

Closed
trsoluti opened this issue Jul 17, 2020 · 9 comments
Labels
C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state regression-from-stable-to-stable Performance or correctness regression from one stable version to another.

Comments

@trsoluti
Copy link

I tried this code:

cargo new cyclone_test
cd cyclone_test
cargo build --target=aarch64-apple-ios

I expected to see this happen: explanation
no errors or warnings
Instead, this happened: explanation
multiple copies of

'+cyclone' is not a recognized feature for this target (ignoring feature)

Meta

rustc --version --verbose:

rustc 1.45.0 (5c1f21c3b 2020-07-13)
binary: rustc
commit-hash: 5c1f21c3b82297671ad3ae1e8c942d2ca92e84f2
commit-date: 2020-07-13
host: x86_64-apple-darwin
release: 1.45.0
LLVM version: 10.0
Backtrace

(not applicable)

@trsoluti trsoluti added the C-bug Category: This is a bug. label Jul 17, 2020
@tesuji
Copy link
Contributor

tesuji commented Jul 17, 2020

"cyclone" has been renamed to "apple-a7" in #73086 .

@tesuji
Copy link
Contributor

tesuji commented Jul 18, 2020

ping @Mark-Simulacrum

@trevyn
Copy link
Contributor

trevyn commented Jul 21, 2020

This is fixed in beta and nightly via #73086. Should probably be nominated for backport to a point release, if there is one.

@Alexendoo Alexendoo added the O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state label Jul 22, 2020
@francesca64
Copy link
Contributor

Is this fixed in 1.45.1?

@Mark-Simulacrum
Copy link
Member

I am confused how it was fixed in beta and nightly by #73086, as it seems that was not backported to beta.

@lzutao -- please ping the whole release team, not just me, so that hopefully someone sees things like this. It would also be helpful to include some mention about why you're pinging rather than just doing so.

This was not fixed in 1.45.1. I am not sure that I am inclined to backport it into stable at all, though, presuming that it is merely an annoyance rather than an error?

@Mark-Simulacrum Mark-Simulacrum added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Jul 30, 2020
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 30, 2020
@francesca64
Copy link
Contributor

@Mark-Simulacrum

presuming that it is merely an annoyance rather than an error?

#73086 (comment) suggests that it "probably also created incorrectly optimized artifacts", though things indeed still build fine. That said, this does result in a lot of messages, i.e. in a largish project I'm seeing it 719 times, which makes it difficult to read any other build output. So at the very least, it's a substantial user experience regression.
Screen Shot 2020-07-30 at 15 32 43

@JohnTitor
Copy link
Member

Removing I-prioritize as this is waiting on backport (but it seems we missed it on 1.45.2?) and already fixed in beta and nightly (related discussion on the wg-prioritization).

@JohnTitor JohnTitor removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 5, 2020
@spastorino
Copy link
Member

@Mark-Simulacrum I think we should close this issue given that we decided to not backport to stable, right?.

@Mark-Simulacrum
Copy link
Member

Given that it's fixed on beta/nightly that does indeed seem reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state regression-from-stable-to-stable Performance or correctness regression from one stable version to another.
Projects
None yet
Development

No branches or pull requests

9 participants