Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Zvalidate-mir should check that SwitchInt values are valid for their type #75440

Closed
oli-obk opened this issue Aug 12, 2020 · 0 comments · Fixed by #78085
Closed

-Zvalidate-mir should check that SwitchInt values are valid for their type #75440

oli-obk opened this issue Aug 12, 2020 · 0 comments · Fixed by #78085
Labels
A-mir-opt Area: MIR optimizations C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Aug 12, 2020

Hypothetically we could have a

SwitchInt {
    switch_ty: u8,
    values: [1, 2, 500],
    ...
}

we expect this not to happen, so this is an invariant of MIR that we can check

cc @rust-lang/wg-mir-opt @RalfJung
@oli-obk oli-obk added the A-mir-opt Area: MIR optimizations label Aug 12, 2020
@oli-obk oli-obk mentioned this issue Aug 12, 2020
Merged
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 12, 2020
@wesleywiser wesleywiser mentioned this issue Oct 18, 2020
Merged
@bors bors closed this as completed in dbdc61f Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mir-opt Area: MIR optimizations C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MIR validation should check SwitchInt values are valid for the type wesleywiser/rust
2 participants
@oli-obk @jonas-schievink