Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mir-opt/instrument_coverage.rs test needs profiler support #75735

Closed
tesuji opened this issue Aug 20, 2020 · 4 comments
Closed

mir-opt/instrument_coverage.rs test needs profiler support #75735

tesuji opened this issue Aug 20, 2020 · 4 comments
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@tesuji
Copy link
Contributor

tesuji commented Aug 20, 2020

mir-opt/instrument_coverage.rs test needs profiler support:

// needs-profiler-support

However, profiler is disable by default:
#profiler = false

So when the test failed I can't notice it in my machine.

P/S: Does profiler need support from LLVM ? I am using local LLVM if that count.

Originally posted by @lzutao in #75670 (comment)

@camelid camelid added the A-self-profile Area: Self-profiling feature of the compiler label Oct 20, 2020
@wesleywiser wesleywiser added A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) and removed A-self-profile Area: Self-profiling feature of the compiler labels Jan 22, 2021
@Enselic Enselic added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2023
@Enselic
Copy link
Member

Enselic commented Dec 28, 2024

Triage: If the problem is that it's disabled by default, what's the problem with enabling it in your local config?

@tesuji
Copy link
Contributor Author

tesuji commented Dec 28, 2024

I have no ideal about this issue since then.
I'd close this issue in this case.

@Enselic
Copy link
Member

Enselic commented Dec 28, 2024

Thanks for getting back, let's close as obsolete then.

@Enselic Enselic closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Dec 28, 2024

That test no longer has //@ needs-profiler-suppport, FTR

//@ compile-flags: -Cinstrument-coverage -Zno-profiler-runtime

thanks to -Zno-profiler-runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants